🦋 Changeset detected

Latest commit: 0b07795

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

is @lukeed aware of this work? am wondering if it would be better to wait for an upstream fix

This won't be needed. And it's @benmccann preparing as a result of lukeed/polka#172 which hasn't been merged or published yet

@lukeed why do you say it won't be needed? Is it because sirv will be updated? Kit is currently failing on unicode routes with adapter-node, but we can hold this and bump polka and sirv instead if you think you'll get a chance to cut a release with the fixes there

Yes of course it will be updated. Your polka PR is a breaking change.

Workaround is not needed w/ recent sirv check. The req._decoded check should have always been in there, since it was sirv's way of preventing duplicate decodeURIComponent calls... but that was only true when it receives a request from a polka@next app, since Polka was writing the decoded value to req.path

Now that the latest polka@next (and express) doesn't decode automatically anymore, req.path isn't trustworthy on its own. It needs req._decoded to be there too in order to trust it.

This combo-check is backwards compatible for polka@next users who don't upgrade.

Thanks @lukeed!! I appreciate the help!

No prob, thanks for the jumpstart & reminder 👍